Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ocassional crashes on 1.9.2 #1096

Closed
iccub opened this issue May 20, 2019 · 2 comments
Closed

Ocassional crashes on 1.9.2 #1096

iccub opened this issue May 20, 2019 · 2 comments
Labels
blocked: needs investigation bug QA Pass - iPhone QA/Yes regression release-notes/exclude
Milestone
1.0.93

Comments

@iccub
Copy link
Contributor

iccub commented May 20, 2019 •
edited by srirambv
Loading

Test plan

See here: #1097

Description:

Steps to Reproduce

  1. Use the app for some time, open some tabs and websites

Actual result:
App crashes with EXC_BAD_ACCESS

Screenshot 2019-05-19 at 8 55 14 PM

Expected result:
Should not crash

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:
1.9.2, also happens on latest development build

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
iccub added a commit to iccub/brave-ios that referenced this issue May 20, 2019
@iccub
Fix brave#1096: App crashes when opening websites.
26c73f5
@danishjafri88 danishjafri88 mentioned this issue May 20, 2019
Closed
jhreis pushed a commit that referenced this issue May 20, 2019
@iccub @jhreis
Fix #1096: App crashes when opening websites. (#1097)
179151e
@srirambv srirambv added this to the 1.0.93 milestone May 20, 2019
@iccub iccub closed this as completed May 20, 2019
@srirambv
Copy link
Contributor

Able to reproduce crash on jbhifi.com.au with following steps

  1. Set fingerprinting on in global shields settings
  2. Open the site in private tab
  3. Visit a few pages on the site and add a few items to shopping cart
  4. Click on shopping cart and click on checkout
  5. Page loads continuously but remain blank
  6. Click on shields, turn of fingerprinting, browser crashes
  7. Repeat the steps again, doesn't crash

cc: @iccub

@srirambv srirambv reopened this May 21, 2019
iccub added a commit to iccub/brave-ios that referenced this issue May 22, 2019
@iccub
Fix brave#1096: Get currentTabUrl before going before going to backgr…
ddef174 
…ound thread.
danishjafri88 added a commit that referenced this issue May 22, 2019
@danishjafri88
Merge pull request #1104 from iccub/bugfix/1096-2
d96f0d2 
Fix #1096: Get currentTabUrl before going before going on bg thread.
@iccub iccub closed this as completed May 22, 2019
kylehickinson added a commit that referenced this issue May 22, 2019
@kylehickinson
Revert "Fix #1096: App crashes when opening websites. (#1097)"
19a6abe 
179151e
@srirambv
Copy link
Contributor

srirambv commented May 23, 2019 •
edited by kjozwiak
Loading

Verification passed on iPhone 7+ and iPad Pro running 1.9.3 (19.05.22.15)

  • Verified browser doesn't randomly crash when navigating jbhifi.com.au / guardianbookshop.com / cyclingweekly.com
  • Verified browser didnt crash when following steps from Ocassional crashes on 1.9.2 #1096 (comment)
  • Verified browser didnt crash when navigating through the site while sync was in progress

Verification passed on iPhone SE running 1.9.3 (19.05.22.15)

Verified passed with iPad (5th Gen) using 1.9.3 (19.05.22.15).

Verification passed on iPhone 8 running 1.9.3 (19.05.22.15)

  • Verified browser doesn't randomly crash when navigating jbhifi.com.au / guardianbookshop.com / cyclingweekly.com
  • Verified browser didnt crash when following steps from Ocassional crashes on 1.9.2 #1096 (comment)
  • Verified browser didnt crash when navigating through the site while sync was in progress

Verification passed on iPad Mini 4 running 1.9.3 (19.05.22.15)

  • Verified browser doesn't randomly crash when navigating jbhifi.com.au / guardianbookshop.com / cyclingweekly.com
  • Verified browser didnt crash when following steps from Ocassional crashes on 1.9.2 #1096 (comment)
  • Verified browser didnt crash when navigating through the site while sync was in progress

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
blocked: needs investigation bug QA Pass - iPhone QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.0.93
Development

No branches or pull requests
6 participants
@kjozwiak @iccub @srirambv @LaurenWags @btlechowski @GeetaSarvadnya