Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Modal screens not taking full screen in iOS 13 #1414

Closed
iccub opened this issue Aug 20, 2019 · 1 comment
Closed

Modal screens not taking full screen in iOS 13 #1414

iccub opened this issue Aug 20, 2019 · 1 comment

Comments

@iccub
Copy link
Contributor

iccub commented Aug 20, 2019

Description:

In iOS 13, view controllers presented modally don't take full screen space, see for example here https://miro.medium.com/max/866/1*JuPvxhMr1isAtYYXG-EDYQ.png

Steps to Reproduce

  1. Open app settings
  2. Observe that it is not full screen (see image)

Actual result:
Zrzut ekranu 2019-08-20 o 11 01 48

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@srirambv
Copy link
Contributor

srirambv commented Sep 7, 2019

Verification passed on iPhone XR with iOS 13.1 running 1.12(19.09.06.17)

  • Verified on a clean install the modal fills the complete screen
  • Verified on upgrade the modal fills the complete screen
  • Verified device orientation doesn't affect the modal when opened and is full screen

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.07.03):

  • ensured that the modal is correctly positioned on a clean install
  • ensured that the modal is correctly position after updating from 1.11.4 (19.8.29.21) to 1.12 (19.09.07.03)
  • ensured that the modal is being positioned correctly when switching between portrait and landscape mode

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants