Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Profile.profile saving to documents directory in Beta Builds #1429

Closed
iccub opened this issue Aug 24, 2019 · 1 comment
Closed

Profile.profile saving to documents directory in Beta Builds #1429

iccub opened this issue Aug 24, 2019 · 1 comment
Assignees
@iccub
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.12

Comments

@iccub
Copy link
Contributor

iccub commented Aug 24, 2019 •
edited by jhreis
Loading

I checked and this only happens on Beta/TF builds, it's due to differences between bundle identifier and a shared container id.

Verification Steps:

  • Go into iOS File app and verify that there is no visible profile.profile file / folder.
@iccub iccub self-assigned this Aug 24, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Aug 24, 2019
@iccub
Fix brave#1429: Correct App Group id for Beta/TestFlight builds.
d53f660
@iccub iccub mentioned this issue Aug 24, 2019
Merged
7 tasks
@jhreis jhreis added this to the 1.12 milestone Aug 27, 2019
@jhreis jhreis added QA/Yes and removed QA/No labels Aug 27, 2019
@jhreis jhreis closed this as completed in 36dfca6 Aug 31, 2019
iccub added a commit that referenced this issue Sep 1, 2019
@iccub
Ref #1429 Use unique id for Beta app group id.
c1efe3d 
For some reason 'com.brave.ios.BrowserBeta' app group id is taken
and can't be used.
iccub added a commit that referenced this issue Sep 2, 2019
@iccub
Ref #1429 Use unique id for Beta app group id. (#1468)
55164d6 
For some reason 'com.brave.ios.BrowserBeta' app group id is taken
and can't be used.
This was referenced Sep 5, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 7, 2019 •
edited
Loading

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.6.21)

  • Verified on a clean install no profile.profile file is created in files folder
  • Verified on a clean install, downloading a file doesn't create profile.profile file
  • Verified on upgrade from Appstore build, no profile.profile file is created
  • Verified on upgrade from Appstore build, downloading a file doesn't create profile.profile file

Verification PASSED on iPad Air 3rd Generation using iOS 13.1 running 1.12 (19.09.12.18):

  • Verified on a clean install no profile.profile file is created in files folder
  • Verified on a clean install, downloading a file doesn't create profile.profile file
  • Verified on upgrade from Appstore build, no profile.profile file is created
  • Verified on upgrade from Appstore build, downloading a file doesn't create profile.profile file

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

  • Verified on a clean install no profile.profile file is created in files folder
  • Verified on a clean install, downloading a file doesn't create profile.profile file
  • Verified on upgrade from Appstore build, no profile.profile file is created
  • Verified on upgrade from Appstore build, downloading a file doesn't create profile.profile file

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@iccub iccub

Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
4 participants
@kjozwiak @jhreis @iccub @srirambv