Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

"Claim my Reward" modal/overlay covering the entire screen and missing button #2255

Closed
kjozwiak opened this issue Jan 29, 2020 · 1 comment
Closed

Comments

@kjozwiak
Copy link
Member

Description:

The Claim my reward modal/overlay for ad grants doesn't match the current specification. The current version is missing the Claim my reward button and covers the entire screen. Because there's no button available, the only thing the user can do is press the X button to close the modal/overlay.

Steps to Reproduce

  1. install 1.14.3 (20.1.28.18) via the Dev TF channel
  2. skip the Onboarding process and go into Settings --> View Rewards Debug Menu
  3. select Staging and restart the browser (should close automatically)
  4. once the browser is relaunched, enable rewards via the panel (Join Rewards)
  5. go into Settings --> View Rewards Debug Menu
  6. restore a wallet that has an ad grant available (use the shared GDoc) and restart the browser
  7. open a new NTP and you'll get the Brave Reward modal that displays your ad grant

Actual result:

IMG_0006 (1)

Expected result:

As per the specification, the modal/overlay should look as follows:

Screen Shot 2020-01-28 at 9 09 11 PM

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version:

  • 1.14.3 (20.1.28.18) (using the Dev TF channel)

Device details:

  • iPhone 11 running iOS 13.3 - Reproduced
  • iPad 3rd Gen running iOS 13.3 - Reproduced
  • iPhone 6s+ running iOS 12.4.1 - Reproduced
  • iPad Mini 4 running iOS 12.4.1 - Reproduced

Website problems only:

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @brave/legacy_qa @anthonypkeane @iccub @jhreis @jamesmudgett

@LaurenWags
Copy link
Member

LaurenWags commented Jan 29, 2020

Verification passed on iPad 5th Gen with iOS 12 running 1.14.3 (20.1.29.20)

Verification passed on iPad Mini with iOS 13 running 1.14.3 (20.1.29.20)

Verification PASSED on iPhone 11 using iOS 13.3 running 1.14.3 (20.1.29.20)

IMG_0019

IMG_0020

Verification PASSED on iPhone 6s+ using iOS 12.4.1 running 1.14.3 (20.1.29.20)

IMG_9998

IMG_9999

Verification passed on 1.14.3(20.01.29.20) on Production on iPhone SE (iOS 12.4)
IMG_0015

Verification passed on 1.14.3(20.01.29.20) on iPhone 8 (IOS 13.3)

IMG_0295

# for free to subscribe to this conversation on GitHub. Already have an account? #.