Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add New Haptic Feedback Behavior #2283

Closed
3 tasks done
anthonypkeane opened this issue Jan 30, 2020 · 3 comments · Fixed by #2312
Closed
3 tasks done

Add New Haptic Feedback Behavior #2283

anthonypkeane opened this issue Jan 30, 2020 · 3 comments · Fixed by #2312

Comments

@anthonypkeane
Copy link

anthonypkeane commented Jan 30, 2020

Add haptic feedback:

  • Selecting sponsored image logo
  • Selecting image credit button on background images.
  • Switching tabs

Internal Chats:
one two

@kjozwiak
Copy link
Member

kjozwiak commented Feb 21, 2020

Verification PASSED on iPhone 11 running iOS 13 using 1.15 (20.02.20.19). Went through the following verifications:

  • ensured that tapping on the credits name on the NTP provided haptic feedback
  • ensured the tapping the NTP SI logo provided haptic feedback
  • ensured that pressing the + button provided haptic feedback (once the new tab was created)
  • ensured that switching between the tabs via the Tab Manager provided haptic feedback

Granted, the vibration is pretty light but seems like it's working on my device. CCing @srirambv.


Verification passed on iPhone XR with iOS 13.4 running 1.15(20.02.20.19)

  • Verified tapping on photo credit has haptic feedback
  • Verified tapping on SI logo has haptic feedback
  • Verified closing a tab has haptic feedback
  • Verified pressing + for new tab has haptic feedback
  • Verified swipe navigation to switch tabs on bottom bar has haptic feedback
  • Verified haptic feedback is noticeable on both normal and private tab

Verification passed on iPhone 7+ with iOS 13.3.1 running 1.15(20.02.20.19)

  • Verified tapping on photo credit has haptic feedback
  • Verified tapping on SI logo has haptic feedback
  • Verified closing a tab has haptic feedback
  • Verified pressing + for new tab has haptic feedback
  • Verified swipe navigation to switch tabs on bottom bar has haptic feedback
  • Verified haptic feedback is noticeable on both normal and private tab

@kjozwiak
Copy link
Member

@anthonypkeane @iccub I'm getting haptic feedback when closing tabs via the toolbar. Expected?

@jhreis
Copy link
Contributor

jhreis commented Feb 24, 2020

@kjozwiak Yes, this is expected. Anytime a tab switches (open, click, close) feedback happens. If you feel any of these is buggy or wrong, we can adjust.

# for free to subscribe to this conversation on GitHub. Already have an account? #.