Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[hackerone] javascript: security isssue #2463

Closed
diracdeltas opened this issue Apr 13, 2020 · 2 comments · Fixed by #2550
Closed

[hackerone] javascript: security isssue #2463

diracdeltas opened this issue Apr 13, 2020 · 2 comments · Fixed by #2550
Assignees
@jumde @jhreis
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include sec-priority security
Milestone
1.17

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Apr 13, 2020 •
edited by jumde
Loading

see https://hackerone.com/reports/846152 or ask yan for details

Test Plan

Specified here: #2550
@diracdeltas
Copy link
Member Author

discussed in Slack, decided solution was just to strip javascript: from the URL bar when pasting

@jhreis jhreis assigned jhreis and unassigned Brandon-T Apr 17, 2020
jhreis added a commit that referenced this issue May 7, 2020
@jhreis
Ref #2463: Initial sanitization approach.
e2a9a91
jumde pushed a commit that referenced this issue May 12, 2020
@jhreis @jumde
Ref #2463: Initial sanitization approach.
cb35061
@jumde jumde mentioned this issue May 13, 2020
Merged
7 tasks
@jhreis jhreis added this to the 1.17 milestone May 14, 2020
jhreis pushed a commit that referenced this issue May 14, 2020
@jumde
Fix #2463: Javascript URLs should only work for bookmarklets (#2550)
7f440d9
This was referenced May 22, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.17(20.5.21.17)

Verification passed on iPhone 7+ with iOS 13.4.5 running 1.17(20.5.21.17)

Verification passed on iPhone 6 with iOS 12.4.5 running 1.17(20.5.21.17)

Verification passed on iPad Pro with iOS 13.4.5 running 1.17(20.5.21.17)

Verification passed on iPad Pro with iOS 12.4.5 running 1.17(20.5.21.17)

@srirambv srirambv mentioned this issue May 29, 2020
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@jumde jumde

@jhreis jhreis

Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include sec-priority security
Projects
None yet
Milestone
1.17
Development

Successfully merging a pull request may close this issue.

Fix #2463: Javascript URLs should only work for bookmarklets brave/brave-ios
5 participants
@diracdeltas @Brandon-T @jumde @jhreis @srirambv