Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Server Publisher List Download causes crash on memory constrained devices #2477

Closed
kylehickinson opened this issue Apr 22, 2020 · 3 comments · Fixed by #2478
Closed

Server Publisher List Download causes crash on memory constrained devices #2477

kylehickinson opened this issue Apr 22, 2020 · 3 comments · Fixed by #2478

Comments

@kylehickinson
Copy link
Collaborator

On memory constrained devices, the server publisher list download will cause a crash

@kylehickinson
Copy link
Collaborator Author

Fixed by brave/brave-core#5301

@kylehickinson kylehickinson added this to the 1.15.2 milestone Apr 22, 2020
@kylehickinson kylehickinson reopened this Apr 22, 2020
@kylehickinson
Copy link
Collaborator Author

Will keep re-opened until merged into iOS

@srirambv
Copy link
Contributor

srirambv commented Apr 23, 2020

  • Verification passed on iPhone 6 with iOS 12.4.5 running 1.15.2(20.04.22.20)
  • Verification passed on iPhone XR with iOS 13.4 running 1.15.2(20.04.22.20)
  • Verification passed on iPad Pro with iOS 13.3.1 running 1.15.2(20.04.22.20)
  • Verification passed on iPad Pro with iOS 12.4.5 running 1.15.2(20.04.22.20)
  • Verified the following on each of the above devices
    Clean Install
- Install 1.15.2
- Skip onboarding
- Add a custom UA
- Visit a image heavy page
- Enable rewards
- Checked console for "OnDownload" request
- No browser lag or hang when that showed up. 
- All verified pub showed verified check on BR panel 

Upgrade Profile

- Install 1.15
- Enable reward and add sites to ac list so rewards db is populated
- Upgrade to 1.15.2
- Disconnect network
- Launch browser and add custom UA 
- Relaunch network and open rewards panel and click on refresh status on the existing page
- No browser lag or hang while console showed "OnDownload" request
- All verified pub showed verified check on BR panel 

Verification passed on iPhone 8 with iOS 13.3.1 running 1.15.2(20.04.22.20)

Clean Install

- Install 1.15.2
- Skip onboarding
- Add a custom UA
- Visit a image heavy page
- Enable rewards
- No browser lag or hang when that showed up. 
- All verified pub showed verified check on BR panel 

Upgrade Profile

- Install 1.15
- Enable reward and add sites to ac list so rewards db is populated
- Upgrade to 1.15.2
- Disconnect network
- Launch browser and add custom UA 
- Relaunch network and open rewards panel and click on refresh status on the existing page
- No browser lag or hang 
- All verified pub showed verified check on BR panel 

Verified test cases using:

  • iPad mini with iOS 13 running 1.15.2(20.04.22.20) (ran each 2x)
  • iPad 5th Gen with iOS 12 running 1.15.2(20.04.22.20) (ran each 3x)

Clean Install

- Install 1.15.2
- Skip onboarding
- Add a custom UA
- Visit a image heavy page
- Enable rewards
- No browser lag or hang when that showed up. 
- All verified pub showed verified check on BR panel 

Upgrade Profile

- Install 1.15
- Enable reward and add sites to ac list so rewards db is populated
- Upgrade to 1.15.2
- Disconnect network
- Launch browser and add custom UA 
- Relaunch network and open rewards panel and click on refresh status on the existing page
- No browser lag or hang 
- All verified pub showed verified check on BR panel 

Verified test cases using the following builds:

  • iPad Mini 4 with iOS 12.4.1 running 1.15.2 (20.04.22.20) (ran each 5x)
  • iPhone 6s+ with iOS 12.4.1 running 1.15.2 (20.04.22.20) (ran each 5x)
  • iPhone 11 with iOS 13.4.1 running 1.15.2 (20.04.22.20) (ran each 5x)

Clean Install

- Install 1.15.2
- Skip onboarding
- Add a custom UA
- Visit a image heavy page
- Enable rewards
- No browser lag or hang when that showed up. 
- All verified pub showed verified check on BR panel 

Upgrade Profile

- Install 1.15
- Enable reward and add sites to ac list so rewards db is populated
- Upgrade to 1.15.2
- Disconnect network
- Launch browser and add custom UA 
- Relaunch network and open rewards panel and click on refresh status on the existing page
- No browser lag or hang 
- All verified pub showed verified check on BR panel 

# for free to subscribe to this conversation on GitHub. Already have an account? #.