Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Reader mode bug #2649

Closed
anthonypkeane opened this issue Jun 19, 2020 · 3 comments · Fixed by #3038
Closed

Reader mode bug #2649

anthonypkeane opened this issue Jun 19, 2020 · 3 comments · Fixed by #3038

Comments

@anthonypkeane
Copy link

Description:

Noticed by @pes10k

if i enable reader mode, and the disable it, the “reader mode tool bar” still stays at the top of the page (the bar with the “Aa” in it)

image

https://bravesoftware.slack.com/archives/C06UXF3KJ/p1592529408466200?thread_ts=1592528199.462000&cid=C06UXF3KJ

@anthonypkeane anthonypkeane added this to the 1.20 milestone Jun 19, 2020
@anthonypkeane anthonypkeane modified the milestones: 1.20, 1.21 Jul 29, 2020
@anthonypkeane anthonypkeane modified the milestones: 1.21, 1.22 Aug 12, 2020
@hennrynusasatria
Copy link

Hi All,

Firefox iOS does not have this Reader Mode bug, Brave iOS is based on Firefox iOS, thus it will be good if Brave iOS follow features updates (as well as bug fixes) from Firefox iOS codebase.

Thank you.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Adding release-notes/include as we're fixing an issue that users have experienced on release.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Verification PASSED using the following build on the following platforms:

1.23 (21.1.28.17)
  • iPad Air (3rd Gen) on iOS 14.3 - PASSED
  • iPad Mini 4 on iOS 13.7 - PASSED
  • iPhone 11 on iOS 14.4 - PASSED
  • iPhone 6+ on iOS 12.4.1 - PASSED

Cases/STR used:

  • ensured the enabling/disabling reader mode didn't leave the toolbar behind
  • ensured that enabling reader mode and then closing Brave didn't leave the toolbar behind once Brave was relaunched
  • ensured that enabling reader mode and editing the text size/colour didn't leave the toolbar behind after disabling reader mode
  • ensured that the reader mode toolbar wasn't visible when switching tabs and than disabling reader mode in the original tab
  • ensured that disabling reader mode on multiple tabs didn't leave the reader mode toolbar behind
  • ensured the above worked on both normal and private tabs

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants