Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update onboarding flow #2832

Closed
iccub opened this issue Aug 21, 2020 · 2 comments · Fixed by #2837
Closed

Update onboarding flow #2832

iccub opened this issue Aug 21, 2020 · 2 comments · Fixed by #2837

Comments

@iccub
Copy link
Contributor

iccub commented Aug 21, 2020

Related ticket
https://github.com/brave/security/issues/199

@iccub iccub added this to the 1.20 milestone Aug 21, 2020
@iccub iccub self-assigned this Aug 21, 2020
@iccub iccub added blocked: needs design Needs design before work can commence and removed blocked: needs design Needs design before work can commence labels Aug 21, 2020
iccub added a commit that referenced this issue Aug 25, 2020
iccub added a commit that referenced this issue Aug 25, 2020
@iccub iccub removed the iOS 14 label Aug 31, 2020
@iccub
Copy link
Contributor Author

iccub commented Sep 1, 2020

Test plan:

  1. No clipboard, no ref code:
  • Have empty clipboard
  • Fresh install the app
  • Verify that no privacy consent onboarding screen is showing
  1. Clipboard, no ref code:
  • Copy random text to clipboard
  • Fresh install the app
  • Verify that privacy consent onboarding screen is showing
  • Choose either option
  • Verify that no sponsored assets are showing
  1. Clipboard, ref code, consent:
  • Fresh install the app using ref code website
  • Verify that privacy consent onboarding screen is showing
  • Choose yes on consent screen
  • (if iOS 14) notice the clipboard alert at the top of the app
  • Verify that sponsored assets are downloaded
  1. Clipboard, ref code, no consent:
  • Fresh install the app using ref code website
  • Verify that privacy consent onboarding screen is showing
  • Choose no on consent screen
  • (if iOS 14) verify that no clipboard alert showed
  • Verify that sponsored assets are downloaded

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2020

Verification passed on iPhone XR with iOS 13.6 running 1.20(20.09.2.14)

No clipboard data
  • Verified no consent message is shown when the clipboard is empty
No ref code/Random text in clipboard
  • Verified copying random text and doing a clean install shows the consent message.
  • Verified 404 record not found message is shown for ref code lookup
Ref code in clipboard and consent to clipboard check
  • Verified clean install via ref code prompts consent message after launch
  • Verified custom tiles and custom NTP assets are shown after check is complete
  • Verified Ref code is shown in logs and captures downloadID
Ref code in clipboard but disagree on clipboard check
  • Verified clean install via ref code prompts consent message after launch
  • Verified declining on consent message still show all custom assets and NTP images
  • Verified Ref code is empty in logs
  • Verified 404 record not found message is shown for ref code lookup
Screenshots
English French German Spanish Japanese
image image image image image

Verification passed on iPhone 7+ with iOS 14 running 1.20(20.09.2.14)

No clipboard data
  • Verified no consent message is shown when the clipboard is empty
No ref code/Random text in clipboard
  • Verified copying random text and doing a clean install shows the consent message.
  • Verified 404 record not found message is shown for ref code lookup
  • Verified clipboard alert is shown
Ref code in clipboard and consent to clipboard check
  • Verified clean install via ref code prompts consent message after launch
  • Verified custom tiles and custom NTP assets are shown after check is complete
  • Verified Ref code is shown in logs and captures downloadID
  • Verified clipboard alert is shown
Ref code in clipboard but disagree on clipboard check
  • Verified clean install via ref code prompts consent message after launch
  • Verified declining on consent message still show all custom assets and NTP images
  • Verified Ref code is empty in logs
  • Verified 404 record not found message is shown for ref code lookup
  • Verified clipboard alert is shown
Screenshots
English French Chinese(Traditional) Italian German
image image image image image

Clipboard message

English French Chinese(Traditional) Italian German
image image image image image

Verification passed on iPad Pro with iOS 12.4.1 running 1.20(20.09.2.14)

No clipboard data
  • Verified no consent message is shown when the clipboard is empty
No ref code/Random text in clipboard
  • Verified copying random text and doing a clean install shows the consent message.
  • Verified 404 record not found message is shown for ref code lookup
Ref code in clipboard and consent to clipboard check
  • Verified clean install via ref code prompts consent message after launch
  • Verified custom tiles and custom NTP assets are shown after check is complete
  • Verified Ref code is shown in logs and captures downloadID
Ref code in clipboard but disagree on clipboard check
  • Verified clean install via ref code prompts consent message after launch
  • Verified declining on consent message still show all custom assets and NTP images
  • Verified Ref code is empty in logs
  • Verified 404 record not found message is shown for ref code lookup
Screenshots
English Russian Chinese(Hong Kong) French Japanese
image image image image image

# for free to subscribe to this conversation on GitHub. Already have an account? #.