Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

HTTPS vs Data Saved #2859

Closed
anthonypkeane opened this issue Sep 2, 2020 · 2 comments · Fixed by #2931
Closed

HTTPS vs Data Saved #2859

anthonypkeane opened this issue Sep 2, 2020 · 2 comments · Fixed by #2931
Assignees
@iccub
Labels
enhancement Epic: Shields QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.23

Comments

@anthonypkeane
Copy link

Description:

Like Android and Desktop, please replace HTTPS with Data Saved on the NTP

Text to be

Est Data Saved
@anthonypkeane anthonypkeane added this to the 1.21 milestone Sep 2, 2020
@bsclifton bsclifton modified the milestones: 1.21, 1.22 Sep 23, 2020
iccub added a commit that referenced this issue Oct 5, 2020
@iccub
Fix #2859: Replace 'https upgrades' with 'data saved' stat.
45c1d72
@iccub iccub mentioned this issue Oct 5, 2020
Merged
7 tasks
@kylehickinson kylehickinson mentioned this issue Oct 19, 2020
Closed
@iccub iccub modified the milestones: 1.22, 1.23 Oct 21, 2020
@iccub iccub added the blocked: needs info Needs further information before work can commence label Jan 21, 2021
iccub added a commit that referenced this issue Jan 22, 2021
@iccub
Fix #2859: Replace 'https upgrades' with 'data saved' stat.
e8676f1
iccub added a commit that referenced this issue Jan 22, 2021
@iccub
Fix #2859: Replace 'https upgrades' with 'data saved' stat.
6c53a94
@iccub iccub added Epic: Shields enhancement release-notes/include and removed blocked: needs info Needs further information before work can commence feature-request labels Jan 22, 2021
@iccub iccub self-assigned this Jan 22, 2021
@iccub
Copy link
Contributor

iccub commented Jan 22, 2021

Related internal ticket
https://github.com/brave/internal/issues/740

iccub added a commit that referenced this issue Jan 26, 2021
@iccub
Fix #2859: Replace 'https upgrades' with 'data saved' stat. (#2931)
c5b7570
iccub added a commit that referenced this issue Jan 26, 2021
@iccub
Fix #2859: Replace 'https upgrades' with 'data saved' stat. (#2931)
a717567
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.23(21.2.10.18)

iPhone 7+ (iOS 14.4) iPhone XR (iOS 13.5) iPad Pro (iOS 12.4.1)
image image

@kjozwiak kjozwiak mentioned this issue Feb 22, 2021
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@iccub iccub

Labels
enhancement Epic: Shields QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

Fix #2859: Replace 'https upgrades' with 'data saved' stat. brave/brave-ios
4 participants
@bsclifton @iccub @anthonypkeane @srirambv