Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update user agent to 14.3 #3020

Closed
iccub opened this issue Nov 9, 2020 · 5 comments · Fixed by #3174
Closed

Update user agent to 14.3 #3020

iccub opened this issue Nov 9, 2020 · 5 comments · Fixed by #3174
Assignees
@iccub
Labels
enhancement Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.23

Comments

@iccub
Copy link
Contributor

iccub commented Nov 9, 2020

No description provided.

@iccub iccub self-assigned this Nov 9, 2020
@iccub iccub mentioned this issue Nov 9, 2020
Merged
7 tasks
@iccub iccub added this to the 1.23 milestone Dec 11, 2020
@iccub iccub changed the title Update user agent to 14.2 Update user agent to 14.3 Jan 5, 2021
@iccub iccub added enhancement Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. QA/Yes release-notes/exclude labels Jan 5, 2021
iccub added a commit that referenced this issue Jan 5, 2021
@iccub
Fix #3020: Update UserAgent to iOS 14.3 version.
2763baf
@iccub iccub mentioned this issue Jan 5, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Jan 6, 2021
@iccub
Fix #3020: Update UserAgent to iOS 14.3 version. (#3174)
5091778
@kjozwiak
Copy link
Member

@iccub quick question, for some reason Brave is listing the OS as 14_3 but Safari is listing it as 14_4 which is correct. Should Brave be listing the same OS version as Safari in this instance?

Brave UA Safari UA
IMG_3544 IMG_3545

@iccub
Copy link
Contributor Author

iccub commented Feb 10, 2021

Are you on iOS 14.3 or 14.4 @kjozwiak?
In this PR we updated user agents to match iOS 14.3, we can update to higher version on next release,
this is a manual process unfortunately

@kjozwiak
Copy link
Member

Are you on iOS 14.3 or 14.4 @kjozwiak?
In this PR we updated user agents to match iOS 14.3, we can update to higher version on next release,
this is a manual process unfortunately

Makes sense 👍 The above device is on 14.4 hence Safari picking that up but sounds like we hardcode ours to match up to 14.3 which makes sense why Brave is displaying 14_3 rather than 14_4.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 10, 2021 •
edited
Loading

  • Verification PASSED on iPhone 11 running iOS 14.4 using 1.23 (21.2.5.15)
Brave UA (Mobile) Safari UA (Mobile)
IMG_3544 IMG_3545
Brave UA (Desktop) Safari UA (Desktop)
IMG_3546 IMG_3547
  • Verification PASSED on iPad Air (3rd Gen) running iOS 14.4 using 1.23 (21.2.5.15)
Brave UA (Mobile) Safari UA (Mobile)
IMG_0200 IMG_0201
Brave UA (Desktop) Safari UA (Desktop)
IMG_0203 IMG_0202
  • Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.23 (21.2.5.15)
Brave UA (Mobile) Safari UA (Mobile)
IMG_0107 IMG_0106
Brave UA (Desktop) Safari UA (Desktop)
IMG_0109 IMG_0108

@kjozwiak
Copy link
Member

@iccub noticing that the versions differ a bit on iOS 13 as well. Differences:

Mobile View

  • OS appears as 13_6_1 under Brave but appears as 13_7 on Safari

Assuming the same case re: iOS 13? We're hardcoded to 13_6_1 but the device is on 13.7 which Safari is picking up?

Desktop View

  • OS appears as 10_15 in Brave but appears as 10_15_4 under Safari
  • Version appears as 13.1 in Brave but appears as 13.1.2 under Safari

Assuming it's expected as it's the same as the current release but wanted to double check 👍

Brave UA (Mobile) Safari UA (Mobile)
IMG_0451 IMG_0450
Brave UA (Desktop) Safari UA (Desktop)
IMG_0449 IMG_0448

@kjozwiak kjozwiak mentioned this issue Feb 22, 2021
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@iccub iccub

Labels
enhancement Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

Fix #3020: Update UserAgent to iOS 14.3 version. brave/brave-ios
2 participants
@kjozwiak @iccub