Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Consider adding WKDataDetectorTypes to our web views #3361

Closed
iccub opened this issue Mar 1, 2021 · 1 comment · Fixed by #3830
Closed

Consider adding WKDataDetectorTypes to our web views #3361

iccub opened this issue Mar 1, 2021 · 1 comment · Fixed by #3830
Assignees
@iccub
Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.28

Comments

@iccub
Copy link
Contributor

iccub commented Mar 1, 2021

https://developer.apple.com/documentation/webkit/wkdatadetectortypes

These types allow websites to have more interactive links, it can turn addresses into Apple Maps handlers, phone numbers and other stuff.
It is off by default in WKWebView, from my tests it looks like all of them are enabled in Safari iOS,
we can consider adding all or some of them in our app, Firefox added it for phone numbers recently.

Related issue in FF: mozilla-mobile/firefox-ios#7814
@iccub iccub added this to the 1.25 milestone Mar 1, 2021
@iccub iccub modified the milestones: 1.25, 1.26 Apr 7, 2021
@iccub iccub modified the milestones: 1.26, 1.27 May 5, 2021
@iccub iccub self-assigned this May 25, 2021
@iccub iccub modified the milestones: 1.27, 1.28 May 26, 2021
iccub added a commit that referenced this issue Jun 22, 2021
@iccub
Fix #3361: Add WKDataDetectorTypes to the app.
8713834
@iccub iccub mentioned this issue Jun 22, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Jun 22, 2021
@iccub
Fix #3361: Add WKDataDetectorTypes to the app. (#3830)
3a460cc
@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2021

Verification passed on the following devices running 1.28(21.7.5.14)

iPhone XR (iOS 13.5) iPhone 7+ (iOS 14.5.1) iPad Pro (iOS 14.6)

@srirambv srirambv mentioned this issue Jul 12, 2021
Closed
@iccub iccub mentioned this issue Aug 25, 2021
Open
iccub added a commit that referenced this issue Apr 12, 2022
@iccub
Ref #3361: Use only phone number data detector type.
66b5e36 
Other types seem to conflict with website's html sometimes, make fonts
to render incorrectly.
@iccub iccub mentioned this issue Apr 12, 2022
Merged
7 tasks
iccub added a commit that referenced this issue Apr 13, 2022
@iccub
Ref #3361: Use only phone number data detector type. (#5246)
f841461 
Other types seem to conflict with website's html sometimes, make fonts
to render incorrectly.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@iccub iccub

Labels
enhancement Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.28
Development

Successfully merging a pull request may close this issue.

Fix #3361: Add WKDataDetectorTypes to the app. brave/brave-ios
2 participants
@iccub @srirambv