Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Shields tooltip shown when tab tray is opened #3461

Closed
srirambv opened this issue Mar 25, 2021 · 1 comment · Fixed by #3604
Closed

Shields tooltip shown when tab tray is opened #3461

srirambv opened this issue Mar 25, 2021 · 1 comment · Fixed by #3604
Assignees
@soner-yuksel
Labels
bug Epic: Shields QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.26

Comments

@srirambv
Copy link
Contributor

Description:

Shields tooltip shown when tab tray is opened

Steps to Reproduce

  1. Clean install
  2. Visit Amazon.com and Wiki in new tabs via favourites
  3. Before tab finishes loading open tab tray
  4. Tooltip shows o tab tray and is interactable

Actual result:

Tooltips.in.Tabtray.MP4

Expected result:
Only show tooltip when shields is shown

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.24(21.3.24.11)

Device details:
iPhone 7+ (iOS 14.4)

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information
@soner-yuksel soner-yuksel self-assigned this Mar 25, 2021
@soner-yuksel soner-yuksel added this to the 1.25 milestone Mar 25, 2021
@iccub iccub modified the milestones: 1.25, 1.26 Apr 7, 2021
@soner-yuksel soner-yuksel mentioned this issue Apr 29, 2021
Merged
7 tasks
soner-yuksel added a commit that referenced this issue May 5, 2021
@soner-yuksel
Fix #3461: Shields tooltip shown when tab tray is opened (#3604)
93808a9
@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iSO 13.5 running 1.26(21.5.26.21)

  • Verified steps from issue description
  • Verified tooltip don't show up when in tab tray
  • Verified tooltip is only shown when tab is focused and page is loaded with shields in view

Verification passed on iPhone 7+ with iSO 14.5.1 running 1.26(21.5.26.21)

  • Verified steps from issue description
  • Verified tooltip don't show up when in tab tray
  • Verified tooltip is only shown when tab is focused and page is loaded with shields in view

Verification passed on iPad Pro with iSO 14.5.1 running 1.26(21.5.26.21)

  • Verified steps from issue description
  • Verified tooltip don't show up when in tab tray
  • Verified tooltip is only shown when tab is focused and page is loaded with shields in view

@kjozwiak kjozwiak mentioned this issue Jun 2, 2021
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@soner-yuksel soner-yuksel

Labels
bug Epic: Shields QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.26
Development

Successfully merging a pull request may close this issue.

Fix #3461: Shields tooltip shown when tab tray is opened brave/brave-ios
4 participants
@kjozwiak @soner-yuksel @iccub @srirambv