-
Notifications
You must be signed in to change notification settings - Fork 448
Update default browser notification to display device's iOS version #3899
Comments
Hey @iccub, I would like to take up this issue! |
sure @Shivakumar-SG, find this notification in app, see how is it implemented. Then this placeholder will be number of device's iOS version, so for iOS 14 it will be 14, for 15=15 etc. |
Hey, I'm kinda new to Xcode and my Xcode app kept crashing and I don't know why. And adding to that, I know git ignores the entire |
thank you for trying @Shivakumar-SG :) |
@iccub If nobody is on this issue yet, I would like to take it. Thanks |
@ionutivan I believe one user has started work on it already, but this PR requires changes |
Description:
This notification should show user's device version instead of hardcoding
iOS 14
On code side this requires change in NSLocalized string, the number has to be replaced with a number placeholder.
Then in app we have to fetch device's iOS version, with iOS 14 minimum, since iOS 13 can't be set as a default
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often: [Easily reproduced, Intermittent Issue]
Brave Version:
Device details:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: