Do not reset to default when global settings are changed

[srirambv]

Description:

Do not reset to default when global settings are changed

Steps to Reproduce

1. Install 1.29
2. Open settings -Shields & Privacy
3. Disable Browsing history and saved logins
4. Close settings menu and reopen, settings are restored to default

Actual result:

Reset.defaults.MP4

Expected result:
Settings changed should retain

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
All

Device details:
All

Website problems only:

• did you check with Brave Shields down? NA
• did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

[srirambv]

Verification passed on iPhone XR with iOS 13.5 running 1.30(21.8.5.11)

• Verified global settings state is retained when settings is closed and reopened

iPhone.XR.Settings.MP4

---

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.30(21.8.5.11)

• Verified global settings state is retained when settings is closed and reopened

iPhone.7+.Settings.MP4

---

Verification passed on iPad Pro with iOS 14.6 running 1.30(21.8.5.11)

• Verified global settings state is retained when settings is closed and reopened

iPad.Pro.Settings.MP4