Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Playlist re-adds videos to list when its removed #4130

Closed
srirambv opened this issue Sep 3, 2021 · 1 comment · Fixed by #4143
Closed

Playlist re-adds videos to list when its removed #4130

srirambv opened this issue Sep 3, 2021 · 1 comment · Fixed by #4143
Assignees
@Brandon-T
Labels
bug Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.31

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2021

Description:

Playlist re-adds videos to list when its removed

Steps to Reproduce

  1. Open two YT videos on two tabs
  2. Add first tab video to Playlist via URL bar button
  3. Open playlist and ensure video is added
  4. Close playlist and switch to second YT tab
  5. Add the video to playlist again via URL bar button
  6. Open playlist
  7. Swipe delete the list items, both get re-added

Actual result:
https://user-images.githubusercontent.com/17010094/131991061-4fce4545-7fd7-4c1c-8846-6649cbe4c87f.MP4

Expected result:
Should not re-add videos back to playlist when its removed

Reproduces how often: [Easily reproduced, Intermittent Issue]
Repro'd once

Brave Version:
1.31(21.9.1.16)

Device details:
iPhone 7+ (iOS 14.5.1)

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @Brandon-T
@srirambv srirambv added this to the 1.31 milestone Sep 3, 2021
This was referenced Sep 3, 2021
Merged
Merged
@iccub iccub linked a pull request Sep 7, 2021 that will close this issue
Fix #4131, #4130, #4129 - Fixes Duplicate items in playlist. Fixes control-center not showing playback info properly. #4143
Merged
7 tasks
iccub pushed a commit that referenced this issue Sep 7, 2021
@Brandon-T
Fix #4131, #4130, #4129, #4102: Fix Duplicate items in playlist, cont…
979caad 
…rol-center not showing playback info properly. (#4143)

This is a release specific commit.
These bugs are fixed already on development branch.
@iccub iccub closed this as completed Sep 7, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Sep 14, 2021 •
edited
Loading

Verification passed on iPhone XR with iOS 13.5 running 1.31(21.9.8.16)

  • Verified steps from issue description
  • Verified playlist doesn't re-add items once its deleted
  • Verified playlist buttons shows correct icon after removing items from playlist

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.31(21.9.8.16)

  • Verified steps from issue description
  • Verified playlist doesn't re-add items once its deleted
  • Verified playlist buttons shows correct icon after removing items from playlist

Verification passed on iPad Pro with iOS 14.6 running 1.31(21.9.8.16)

  • Verified steps from issue description
  • Verified playlist doesn't re-add items once its deleted
  • Verified playlist buttons shows correct icon after removing items from playlist

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.31
3 participants
@Brandon-T @iccub @srirambv