Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Selecting Swap from a token doesn't set it as the swap from token #4677

Closed
srirambv opened this issue Dec 9, 2021 · 1 comment · Fixed by #4756
Closed

Selecting Swap from a token doesn't set it as the swap from token #4677

srirambv opened this issue Dec 9, 2021 · 1 comment · Fixed by #4756
Assignees
@nuo-xu
Labels
bug Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.35

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 9, 2021

Description:

Selecting Swap from a token doesn't set it as the swap from token

Steps to Reproduce

  1. Create/Restore wallet
  2. Select BAT from portfolio
  3. Select swap on the token details page
  4. Swap sheet opens up but its set fro Swap from ETH to BAT instead of Swap from BAT to ETH

Actual result:
Selecting Swap from a token doesn't set it as the swap from token

Expected result:
Should set BAT as swap from token as swap was initiated from that asset details page

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.33

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@nuo-xu nuo-xu self-assigned this Dec 20, 2021
@nuo-xu nuo-xu mentioned this issue Dec 20, 2021
Merged
7 tasks
@nuo-xu nuo-xu added this to the 1.34 milestone Dec 20, 2021
@soner-yuksel soner-yuksel modified the milestones: 1.34, 1.35 Jan 4, 2022
nuo-xu added a commit that referenced this issue Jan 12, 2022
@nuo-xu
Fix #4677: Prefill default buy/send/swap token if user comes from tok…
8ae3f1c 
…en details screen (#4756)
@srirambv
Copy link
Contributor Author

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.35 (22.1.24.23)

  • Verified steps from #4756
  • Verified selecting an asset from portfolio page and selecting Buy/Send/Swap from asset page prepopulates the token in Buy/Send/Swap from fields
  • Verified on Mainnet selecting Buy sets BAT as default asset to be bought
  • Verified on Mainnet selecting Send sets ETH as default token
  • Verified on Mainnet selecting Swap sets ETH as from and BAT as to token
  • Verified on Ropsten selecting Swap sets ETH as preselected from token and DAI as preselected to token
  • Encountered #4893

Verification passed on iPhone XR with iOS 14.8.1 running 1.35 (22.1.24.23)

  • Verified steps from #4756
  • Verified selecting an asset from portfolio page and selecting Buy/Send/Swap from asset page prepopulates the token in Buy/Send/Swap from fields
  • Verified on Mainnet selecting Buy sets BAT as default asset to be bought
  • Verified on Mainnet selecting Send sets ETH as default token
  • Verified on Mainnet selecting Swap sets ETH as from and BAT as to token
  • Verified on Ropsten selecting Swap sets ETH as preselected from token and DAI as preselected to token
  • Encountered #4893

Verification passed on iPad Pro with iOS 15.3 running 1.35 (22.1.24.23)

  • Verified steps from #4756
  • Verified selecting an asset from portfolio page and selecting Buy/Send/Swap from asset page prepopulates the token in Buy/Send/Swap from fields
  • Verified on Mainnet selecting Buy sets BAT as default asset to be bought
  • Verified on Mainnet selecting Send sets ETH as default token
  • Verified on Mainnet selecting Swap sets ETH as from and BAT as to token
  • Verified on Ropsten selecting Swap sets ETH as preselected from token and DAI as preselected to token
  • Encountered #4893

@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@nuo-xu nuo-xu

Labels
bug Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.35
4 participants
@kylehickinson @nuo-xu @soner-yuksel @srirambv