Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Some HTML properties not configurable in Brave-iOS #4871

Closed
Brandon-T opened this issue Jan 21, 2022 · 1 comment · Fixed by #4872
Closed

Some HTML properties not configurable in Brave-iOS #4871

Brandon-T opened this issue Jan 21, 2022 · 1 comment · Fixed by #4872

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • HTMLMediaElement, HTMLAudioElement, and HTMLVideoElement do not have a configurable src attribute.

Steps to Reproduce

  1. Visit: https://app.close.com/

Actual result:

  • Login screen not showing

Expected result:

  • Login screen should show.

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced

Brave Version:
All

Device details:
All

Website problems only:

  • Yes that specific website only.
  • The HTMLMediaElement.src property is being redefined by the website developers. I do not see anywhere in ECMAScript that says it must be configurable or not so it seems to be implementation defined(??)

Additional Information

  • Solution is to default to whatever WebKit implements. This might break playlist and/or video and audio for some website that decides to change the native implementation of the property (especially if they don't call the original function [trampoline]), but not sure.
@Brandon-T Brandon-T self-assigned this Jan 21, 2022
@Brandon-T Brandon-T changed the title Some properties not configurable in Brave-iOS Some HTML properties not configurable in Brave-iOS Jan 21, 2022
@iccub iccub added this to the 1.35 milestone Jan 21, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jan 25, 2022

Verification PASSED on iPhone 12 running iOS 15.1.1 using 1.35 (22.1.24.23)

1.34 (22.1.10.19) 1.35 (22.1.24.23)
IMG_0533 IMG_0534

Verification PASSED on iPhone 11 running iOS 14.7.1 using 1.35 (22.1.24.23)

1.34 (22.1.10.19) 1.35 (22.1.24.23)
IMG_3766 IMG_3767

Verification PASSED on iPad Air (3rd Gen) running iOS 15.2 using 1.35 (22.1.24.23)

1.34 (22.1.10.19) 1.35 (22.1.24.23)
IMG_0349 IMG_0350

# for free to subscribe to this conversation on GitHub. Already have an account? #.