Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add badge to wallet url bar icon when pending request available #5358

Closed
StephenHeaps opened this issue May 18, 2022 · 1 comment · Fixed by #5383
Closed

Add badge to wallet url bar icon when pending request available #5358

StephenHeaps opened this issue May 18, 2022 · 1 comment · Fixed by #5383
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.40

Comments

@StephenHeaps
Copy link
Contributor

Description:

When there is a pending request from a dapp site, we should show a badge to the wallet icon/button in the URL bar.

Screen Shot 2022-05-18 at 1 59 07 PM

Additional Information

See 'In Planning - 0.1 Mobile Dapp Support/Hide notif. banner' in Figma
@StephenHeaps StephenHeaps self-assigned this May 19, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 May 20, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. label May 20, 2022
@StephenHeaps StephenHeaps mentioned this issue May 25, 2022
Merged
7 tasks
StephenHeaps added a commit that referenced this issue May 30, 2022
@StephenHeaps
Fix #5358: Badge on wallet button in URL bar for pending requests (#5383
5323fca 
)

* Added `ButtonState.activeWithPendingRequest`, add badge to `WalletURLBarButton` when using new button state.
* Update wallet url bar button with badge when a pending request is available
* Fix wallet button not updating to remove badge after giving web3 permissions with no other pending requests
Repository owner moved this from Backlog to Done in Web3 May 30, 2022
@StephenHeaps StephenHeaps added this to the 1.40 milestone May 30, 2022
@StephenHeaps StephenHeaps mentioned this issue May 30, 2022
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8.1 devices running 1.40 (22.6.24.14)

  • Verified steps from #5383
  • Verified connecting to Dapp and closing the connect window shows a notification dot on the wallet button
  • Verified when there are no pending requests no bell icon is shown in panel or in wallet screen
  • Verified creating a pending transaction from wallet and then visiting a Dapp triggers the wallet icon and shows a dot on the icon
  • Verified accepting/rejecting a pending transaction automatically removes the badge on the wallet
  • Verified Display Web3 Notifications in Brave Wallet setting is set to enabled by default
  • Verified disabling Display Web3 Notifications doesn't show any Dapp notification.
  • Verified disabling Display Web3 Notifications continues to show the badge on wallet icon when there is a pending request

Verification passed on iPhone XR with iOS 15.4.1 running 1.40 (22.6.24.14)

  • Verified steps from #5383
  • Verified connecting to Dapp and closing the connect window shows a notification dot on the wallet button
  • Verified when there are no pending requests no bell icon is shown in panel or in wallet screen
  • Verified creating a pending transaction from wallet and then visiting a Dapp triggers the wallet icon and shows a dot on the icon
  • Verified accepting/rejecting a pending transaction automatically removes the badge on the wallet
  • Verified Display Web3 Notifications in Brave Wallet setting is set to enabled by default
  • Verified disabling Display Web3 Notifications doesn't show any Dapp notification.
  • Verified disabling Display Web3 Notifications continues to show the badge on wallet icon when there is a pending request

Verification passed on iPad Pro+ with iOS 15.6 Beta running 1.40 (22.6.24.14)

  • Verified steps from #5383
  • Verified connecting to Dapp and closing the connect window shows a notification dot on the wallet button
  • Verified when there are no pending requests no bell icon is shown in panel or in wallet screen
  • Verified creating a pending transaction from wallet and then visiting a Dapp triggers the wallet icon and shows a dot on the icon
  • Verified accepting/rejecting a pending transaction automatically removes the badge on the wallet
  • Verified Display Web3 Notifications in Brave Wallet setting is set to enabled by default
  • Verified disabling Display Web3 Notifications doesn't show any Dapp notification.
  • Verified disabling Display Web3 Notifications continues to show the badge on wallet icon when there is a pending request

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40
Development

Successfully merging a pull request may close this issue.

Fix #5358: Badge on wallet button in URL bar for pending requests brave/brave-ios
3 participants
@jamesmudgett @StephenHeaps @srirambv