Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update user rating prompt logic #5722

Closed
iccub opened this issue Jul 20, 2022 · 3 comments · Fixed by #6210
Closed

Update user rating prompt logic #5722

iccub opened this issue Jul 20, 2022 · 3 comments · Fixed by #6210
Assignees
@soner-yuksel
Labels
enhancement QA/No release-notes/include
Milestone
1.45

Comments

@iccub
Copy link
Contributor

iccub commented Jul 20, 2022

details tba
@timchilds
Copy link
Collaborator

timchilds commented Oct 12, 2022 •
edited
Loading

@iccub here is the Android spec for this:
https://docs.google.com/document/d/1SN4Tdu0WUkyvnCkuVy76T34GJgNH3fBGEtgobme4YS4/edit?usp=sharing

I think we can likely re-use all/some of the logic. But unsure if iOS has an equivalent API for displaying the review prompt in-app? https://developer.android.com/guide/playcore/in-app-review

cc @anthonypkeane @Sam-Sibley

@iccub
Copy link
Contributor Author

iccub commented Oct 12, 2022

thanks @timchilds

@soner-yuksel soner-yuksel self-assigned this Oct 19, 2022
@soner-yuksel soner-yuksel added this to the 1.45 milestone Oct 19, 2022
@soner-yuksel soner-yuksel mentioned this issue Oct 19, 2022
Merged
26 tasks
soner-yuksel added a commit that referenced this issue Oct 27, 2022
@soner-yuksel
Fix #5722: Update user rating prompt logic (#6210)
edef1d2
@soner-yuksel soner-yuksel mentioned this issue Nov 3, 2022
Closed
5 tasks
@Uni-verse
Copy link
Contributor

Removing QA/Yes label as QA were not able to test the user rating prompt logic in TF builds.

CC: @kjozwiak

@srirambv srirambv mentioned this issue Nov 15, 2022
Closed
@data-sync-user data-sync-user mentioned this issue Jan 6, 2025
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement QA/No release-notes/include
Projects
None yet
Milestone
1.45
Development

Successfully merging a pull request may close this issue.

Fix #5722: Update user rating prompt logic brave/brave-ios
5 participants
@kjozwiak @soner-yuksel @iccub @Uni-verse @timchilds