Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet: Remove url reference from send token to address field placeholder #5786

Closed
StephenHeaps opened this issue Aug 4, 2022 · 1 comment · Fixed by #5788
Closed

Wallet: Remove url reference from send token to address field placeholder #5786

StephenHeaps opened this issue Aug 4, 2022 · 1 comment · Fixed by #5788
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.42

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Aug 4, 2022 •
edited
Loading

Description:

Sending to a url is not currently supported on iOS, but the placeholder copy in the to address field suggests we do. We should remove the reference to url until that is supported.

ref: #5719 (comment)

Enter address or url Simulator Screen Shot - iPhone 13 Pro Max - 2022-08-04 at 18 19 11
@StephenHeaps StephenHeaps added this to the 1.42 milestone Aug 4, 2022
@StephenHeaps StephenHeaps added this to Web3 Aug 4, 2022
@StephenHeaps StephenHeaps mentioned this issue Aug 4, 2022
Merged
11 tasks
nuo-xu pushed a commit that referenced this issue Aug 4, 2022
@StephenHeaps
Fix #5786 : Update placeholder copy to remove url reference from to a…
6a539ec 
…ddress field (#5788)
@nuo-xu nuo-xu moved this to Done in Web3 Aug 4, 2022
@nuo-xu nuo-xu added the QA/Yes label Aug 5, 2022
@StephenHeaps StephenHeaps self-assigned this Aug 8, 2022
@srirambv
Copy link
Contributor

srirambv commented Aug 9, 2022

Verification passed on the following devices running 1.42 (22.8.8.19)

  • Verified test plan from ##5788
  • Verified refence of URL is removed from Send address field
  • Verified entering a valid URL still shows the error message
iPhone 7+ (iOS 14.8.1) iPhone XR (iOS 15.4.1) iPad Pro (iOS 15.6 Beta)

@srirambv srirambv mentioned this issue Aug 19, 2022
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42
Development

Successfully merging a pull request may close this issue.

Fix #5786 : Update placeholder copy to remove url reference from to address field brave/brave-ios
3 participants
@nuo-xu @StephenHeaps @srirambv