Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Brave VPN should use WireGuard by default #6646

Closed
bsclifton opened this issue Dec 15, 2022 · 1 comment · Fixed by #7125 or #7332
Closed

Brave VPN should use WireGuard by default #6646

bsclifton opened this issue Dec 15, 2022 · 1 comment · Fixed by #7125 or #7332
Assignees
@soner-yuksel
Labels
enhancement Epic: VPN QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.50

Comments

@bsclifton
Copy link
Member

Problem Description

Our current VPN integration (using GuardianConnect library) is using IKEv2 protocol. This can be problematic for some folks who are connected to VPN while on WiFi. The root cause is unknown, but their WiFi connection will drop. Please see #6645

Feature Overview

GuardianConnect has the ability to use WireGuard as the protocol. We'd need to make some changes to our code-base

Design

We shouldn't need a design unless we wanted to let the user choose. If we let the user choose, we may want to default to WireGuard.
@soner-yuksel soner-yuksel added this to the 1.50 milestone Mar 21, 2023
@soner-yuksel soner-yuksel self-assigned this Mar 21, 2023
@soner-yuksel soner-yuksel mentioned this issue Mar 21, 2023
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Apr 6, 2023
@soner-yuksel
Fix #6646: Brave VPN should use WireGuard Protocol by default (#7125)
b1ba424
iccub added a commit that referenced this issue Apr 14, 2023
@iccub
Ref #6646: Update GuardianConnect to 1.8.1
8a25304
@iccub iccub mentioned this issue Apr 14, 2023
Merged
11 tasks
iccub added a commit that referenced this issue Apr 14, 2023
@iccub
Ref #6646: Update GuardianConnect to 1.8.1 (#7251)
b0d6bf4
iccub added a commit that referenced this issue Apr 14, 2023
@iccub
Ref #6646: Update GuardianConnect to 1.8.1 (#7251)
e9289e7
@soner-yuksel soner-yuksel mentioned this issue Apr 25, 2023
Merged
11 tasks
@soner-yuksel soner-yuksel linked a pull request Apr 25, 2023 that will close this issue
Ref #6646: Region Change with preferred Tunnel #7332
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Apr 25, 2023
@soner-yuksel
Ref #6646: Region Change with preferred Tunnel (#7332)
ab44a93
soner-yuksel added a commit that referenced this issue Apr 25, 2023
@soner-yuksel
Ref #6646: Region Change with preferred Tunnel (#7332)
8a5d3c6
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.3.1 using version 1.50 (23.4.25.20)

Using Test Plan in PR - #7125 (comment)

Fresh User

  • Ensured purchasing a new VPN subscription is successful
  • Ensured that VPN profile is set and connection is established

Existing Plan

  • Ensured that resetting VPN configuration will set new VPN profile and establish a connection.
Example Example Example Example Example Example Example
IMG_3015 2 IMG_3016 2 IMG_3017 2 IMG_3018 2 IMG_3019 2 IMG_3020 2 IMG_3023 3

@Uni-verse Uni-verse mentioned this issue May 5, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#6646: Brave VPN should use WireGuard Protocol by …
cdfb403 
…default (brave/brave-ios#7125)
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Ref brave/brave-ios#6646: Update GuardianConnect to 1.8.1 (brave/brav…
33b8c95 
…e-ios#7251)
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@soner-yuksel
Ref brave/brave-ios#6646: Region Change with preferred Tunnel (brave/…
18d711b 
…brave-ios#7332)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement Epic: VPN QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.50
4 participants
@bsclifton @soner-yuksel @iccub @Uni-verse