Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Auto-complete adding custom Solana asset(s) #6982

Closed
StephenHeaps opened this issue Feb 21, 2023 · 1 comment · Fixed by #6990
Closed

Auto-complete adding custom Solana asset(s) #6982

StephenHeaps opened this issue Feb 21, 2023 · 1 comment · Fixed by #6990
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.49

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Feb 21, 2023 •
edited
Loading

Description:

Entering a token mint address when adding a Solana custom asset should auto-complete the fields when possible.

ex. USD Coin with mint address EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v

Simulator.Screen.Recording.-.iPhone.12.Pro.-.2023-02-22.at.10.45.49.mp4
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Feb 21, 2023
@StephenHeaps StephenHeaps self-assigned this Feb 22, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Feb 22, 2023
@StephenHeaps StephenHeaps added this to the 1.49 milestone Feb 22, 2023
@StephenHeaps StephenHeaps mentioned this issue Feb 22, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps moved this from In Progress to In Review in Web3 Feb 22, 2023
StephenHeaps added a commit that referenced this issue Feb 22, 2023
@StephenHeaps
Fix #6982: Auto-complete adding known custom assets (#6990)
45b4919 
* Fix auto-complete for adding custom tokens not using our token lists for non-ethereum addresses (ex. Solana tokens)
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 22, 2023
@srirambv
Copy link
Contributor

srirambv commented Mar 6, 2023 •
edited
Loading

Verification passed on the following devices running 1.

  • Verified steps from #6990
  • Verified adding custom Solana tokens automatically fills in the details when address is pasted in
  • Verified able to still add Ethereum address and auto-complete the token details
iPhone XR (iOS 15.7.1) iPad Pro (16.4 Beta 2)
6982-iPhone.XR.mov
6982-iPad.Pro.MP4

@srirambv srirambv mentioned this issue Apr 14, 2023
Merged
11 tasks
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#6982: Auto-complete adding known custom assets (b…
ddd873c 
…rave/brave-ios#6990)

* Fix auto-complete for adding custom tokens not using our token lists for non-ethereum addresses (ex. Solana tokens)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #6982: Auto-complete adding known custom assets brave/brave-ios
2 participants
@StephenHeaps @srirambv