Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Cleanup ContentBlockerManager and improve its speed. #7147

Closed
cuba opened this issue Mar 24, 2023 · 1 comment · Fixed by #7131
Closed

Cleanup ContentBlockerManager and improve its speed. #7147

cuba opened this issue Mar 24, 2023 · 1 comment · Fixed by #7131

Comments

@cuba
Copy link
Contributor

cuba commented Mar 24, 2023

Description:

The content blocker manager uses a timed sync mechanism. Because apple caches rule lists, this is actually not needed. We don't need to recompile anything on re-launches, just when settings and data changes.

This caching way makes it very difficult to work with custom filter lists and adds extra overhead on background threads for no reason.

Additional Information

@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.3.1 using version 1.50 (23.4.25.20)

Using Test Plan in #7131 (comment)

  • Ensured that page has true for all values when loading https://test-pages.privacytests.org/tracking_content.html.
  • Ensured that app launches relatively quickly with many filters enabled in the content filtering.
  • Ensured that cosmetic filtering is working when loading twitter.com or reddit.com
  • Ensured that script loading test page is passing, showing true when shields are up and null when shields down - https://dev-pages.brave.software/filtering/scriptlets.html
Example Example Example Example Example Example
IMG_3028 2 IMG_3030 IMG_3031 2 IMG_3032 2 IMG_3034 2 IMG_3036

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants