Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Stop Recommending Alexa Top Sites for Search Suggestions. #868

Closed
anthonypkeane opened this issue Feb 6, 2019 · 9 comments
Closed

Stop Recommending Alexa Top Sites for Search Suggestions. #868

anthonypkeane opened this issue Feb 6, 2019 · 9 comments
Assignees
@iccub
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.13

Comments

@anthonypkeane
Copy link

We currently autocomplete urls with a list from https://github.com/brave/brave-ios/blob/development/Client/Assets/topdomains.txt

With a clean history it will autosuggest sites, if you start typing letters in the url bar
for example: on a fresh app type letter k in the url bar, it will fill rest of the url to kohls.com

We need to decide if this is good practice or not
@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2019

#807 should also be considered as part of the fix for this

@jhreis jhreis added blocked: needs info Needs further information before work can commence QA/Yes release-notes/exclude labels Mar 19, 2019
@jhreis jhreis removed the blocked: needs info Needs further information before work can commence label Apr 1, 2019
@jhreis
Copy link
Contributor

jhreis commented Apr 1, 2019

Completely kill this feature, and all topdomains.txt related logic.

@jamesmudgett
Copy link
Contributor

IMG_2781

@jamesmudgett
Copy link
Contributor

Remove topdomains from autofill

@anthonypkeane anthonypkeane mentioned this issue May 14, 2019
Closed
@anthonypkeane anthonypkeane mentioned this issue Jun 6, 2019
Closed
@jhreis jhreis changed the title Figure out how we handle url autofill Stop Recommending Alexa Top Sites for Search Suggestions. Aug 13, 2019
@iccub iccub assigned iccub and unassigned jamesmudgett and anthonypkeane Sep 24, 2019
iccub added a commit that referenced this issue Sep 24, 2019
@iccub
Fix #868: Remove Alexa search suggestions for url autofill.
b2b3c07
@iccub iccub mentioned this issue Sep 24, 2019
Merged
7 tasks
@iccub iccub added this to the 1.13 milestone Sep 26, 2019
@iccub iccub closed this as completed in 6b3cf24 Sep 26, 2019
@srirambv
Copy link
Contributor

@jamesmudgett @iccub is there a limit for the number of history/bookmark items show up when typing in?

@anthonypkeane
Copy link
Author

@jamesmudgett @iccub is there a limit for the number of history/bookmark items show up when typing in?

5

@srirambv
Copy link
Contributor

@anthonypkeane I am seeing 7
image

@anthonypkeane
Copy link
Author

It is ok and we can tidy it up in later builds.

@srirambv srirambv mentioned this issue Oct 18, 2019
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone Xr with iOS 13.2 running 1.13(19.10.18.15)

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.18.15)

  • Verified Alexa top sites are not shown as recommendations on a clean profile
  • Verified only sites from bookmark/history is shown in the suggestion list

Verification passed on iPhone 6 with iOS 13.2 running 1.13(19.10.18.15)

  • Verified Alexa top sites are not shown as recommendations on a clean profile
  • Verified only sites from bookmark/history is shown in the suggestion list

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.10.18.15)

  • Verified Alexa top sites are not shown as recommendations on a clean profile
  • Verified only sites from bookmark/history is shown in the suggestion list

@srirambv srirambv mentioned this issue Nov 8, 2019
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
5 participants
@jamesmudgett @jhreis @iccub @anthonypkeane @srirambv