Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1388: Cancel queued key sessions on cleanup #1396

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 15, 2019

Fix #1388

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • My patch or PR title has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup! (or No Bug: <message> if no relevant ticket)
  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New files have MPL-2.0 license header.

Test Plan:

  1. Navigate to demo.yubico.com
  2. Try the cancel/retry workflow with registration and authentication
  3. App should not crash

Reviewer Checklist:

  • PR is linked to an issue via Zenhub.
  • Issues are assigned to at least one epic.
  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable)

@jumde jumde requested review from iccub, jhreis and Brandon-T August 15, 2019 00:08
@jumde jumde self-assigned this Aug 15, 2019
@Brandon-T
Copy link
Collaborator

Looks good. Doesn't crash anymore. :)

@jhreis jhreis merged commit c2f744f into development Aug 20, 2019
@jhreis jhreis deleted the cancel_commands branch August 20, 2019 18:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave crashing often when cancelling/retrying under demo.yubico.com/u2f
5 participants