Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

fix error color to red #1832

Closed
wants to merge 1 commit into from

Conversation

izabekz
Copy link

@izabekz izabekz commented Oct 30, 2019

Summary of Changes

This pull request fixes issue #1818

Submitter Checklist:

  • [checked] Unit Tests are updated to cover new or changed functionality
  • [checked] User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a screenshot on how the pin screen looks after the fix?

@jhreis
Copy link
Contributor

jhreis commented Oct 31, 2019

In this case, for both iOS 13 and iOS 12 would be nice (for screenshots). Can use the simulator. If you are unable to do this, just let us know.

@izabekz
Copy link
Author

izabekz commented Oct 31, 2019

@iccub @jhreis will add as soon as i will solve error when building, tomorrow after work, sorry for inconvenience

@iccub
Copy link
Contributor

iccub commented Nov 19, 2019

Fixed in #1975, thanks for your contribution anyway :)

@iccub iccub closed this Nov 19, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants