Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #2556: Show correct total BAT balance #2557

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented May 15, 2020

Summary of Changes

This pull request fixes #2556

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Ensure environment is prod, Enable Rewards
  • Import Jimmy's DB (and force-quit/relaunch)
  • Ensure it shows 33 BAT balance
  • (Reset Rewards/delete app after so you don't spend his BAT 😜)

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson
Copy link
Collaborator Author

kylehickinson commented May 15, 2020

Please do not delete branch after merge (will end up being the v1.16.2 tag)

@kylehickinson kylehickinson merged commit ef76934 into development May 15, 2020
@kylehickinson kylehickinson deleted the bat-display-fix branch May 15, 2020 21:51
@kylehickinson kylehickinson restored the bat-display-fix branch May 15, 2020 21:51
@kylehickinson kylehickinson deleted the bat-display-fix branch August 5, 2020 16:33
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total balance does not include old promotions
2 participants