This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 448
Fix#2980: Educational in-product Notification #3151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
suggested changes
Dec 16, 2020
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
5f97e02
to
3b04919
Compare
This was
linked to
issues
Dec 16, 2020
Closed
Brandon-T
approved these changes
Dec 22, 2020
Brandon-T
suggested changes
Dec 23, 2020
b275c01
to
cf6dfb6
Compare
Brandon-T
suggested changes
Dec 23, 2020
iccub
suggested changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at both this review and the other PR, i did not notice they are based off each other
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
kylehickinson
suggested changes
Jan 5, 2021
01f4b5f
to
ff510f9
Compare
caa6200
to
5b915db
Compare
0a570de
to
93f7322
Compare
iccub
suggested changes
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Show resolved
Hide resolved
iccub
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99,9% ready last nitpicks left :)
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ProductNotification.swift
Outdated
Show resolved
Hide resolved
Brandon-T
approved these changes
Jan 14, 2021
7 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding functionality to educational in-product notifications.
The added functionality can be states as follows.
Notification types will be shown
And also Brave Benchmark Tiers are added so every tier user will be shown a notification regarding to which level they are and sharing options for Issue #2981
Please refer to respected documents for details.
Summary of Changes
This pull request fixes #2980
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
release-notes/(include|exclude)
bug
/enhancement