Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3656 - Fixing long-press for playlists nagging the user #3659

Merged
merged 1 commit into from
May 11, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented May 10, 2021

Summary of Changes

  • Fixing long-press for playlists by hacking in a UILongPressGestureRecognizer

This pull request fixes #3656

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

STR in the ticket, it's similar to #3616

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@Brandon-T
Copy link
Collaborator Author

There is no other way to fix this via JS as the touchmove function gets called at a platform specific polling rate.

@Brandon-T Brandon-T force-pushed the bugfix/LongPressPlaylist branch from 5c7d8fc to 10b8507 Compare May 10, 2021 19:03
@Brandon-T Brandon-T merged commit 3aee532 into development May 11, 2021
@Brandon-T Brandon-T deleted the bugfix/LongPressPlaylist branch May 11, 2021 14:41
@iccub iccub added this to the 1.26 milestone May 11, 2021
@kylehickinson kylehickinson modified the milestones: 1.26, 1.25.1 May 21, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Playlist pop-up on YouTube - Even with feature disabled
4 participants