Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3726, #3727 - Playlist not showing in Toast or Share Menu for some sites #3728

Merged
merged 2 commits into from
May 26, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented May 26, 2021

Summary of Changes

  • Some sites are using setAttribute and others are setting the src property directly.
  • This code hooks both so that playlist works properly on all sites.
  • This was a regression due to the performance fix that removed mutation observers.
  • We will have no performance impact with this code, but we'll have support for more sites :)

This pull request fixes #3726, #3727

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.26 milestone May 26, 2021
@iccub iccub merged commit 711b035 into development May 26, 2021
@iccub iccub deleted the bugfix/Playlist-Sites branch May 26, 2021 16:37
iccub pushed a commit that referenced this pull request May 26, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listennotes.com isn't recognized to save for playlist
2 participants