Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3863 Changing logic regarding accepting url and text from share extension #3864

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

KacperWybranski
Copy link
Contributor

@KacperWybranski KacperWybranski commented Jun 29, 2021

Summary of Changes

This pull request fixes #3863
Logic changed from checking whether shared item is URL or text in NSItemProvider.loadItem to check it in Scheme initializer after accepting text data to app.

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Verify that sharing url or text from other apps have not regressed

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@KacperWybranski KacperWybranski changed the title Fix #3863 Fix #3863 Changing logic regarding accepting url and text from share extension Jun 29, 2021
@KacperWybranski
Copy link
Contributor Author

With this code, sharing text "https://www.apple.com apple" will cause searching with default search engine rather than opening first url in the string but it can be easily changed based on your opinion.

@kylehickinson kylehickinson requested a review from iccub June 29, 2021 16:42
@iccub
Copy link
Contributor

iccub commented Jun 29, 2021

Thanks for this PR, let's wait with it until security review passes for our preview url scheme code, cc @jumde

@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jun 29, 2021
@iccub iccub added this to the 1.29 milestone Jun 30, 2021
@iccub
Copy link
Contributor

iccub commented Jul 20, 2021

this is now unblocked, will be delivered later, one release after your original search scheme pull request

@iccub iccub removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jul 20, 2021
@iccub iccub modified the milestones: 1.29, 1.30 Jul 20, 2021
@iccub iccub merged commit 863dd77 into brave:development Aug 2, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL item shared to Brave is not recognized as URL type
2 participants