This repository has been archived by the owner on May 10, 2024. It is now read-only.
Implement Bookmark All Tabs Long-Press Action #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
suggested changes
Sep 6, 2021
Client/Frontend/Browser/BrowserViewController/BrowserViewController+ToolbarDelegate.swift
Outdated
Show resolved
Hide resolved
...ntend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift
Outdated
Show resolved
Hide resolved
...ntend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift
Outdated
Show resolved
Hide resolved
Brandon-T
suggested changes
Sep 7, 2021
iccub
reviewed
Sep 8, 2021
| style: .default, handler: { [unowned self] _ in | ||
|
|
||
| let addBookMarkController = AddEditBookmarkTableViewController( | ||
| mode: BookmarkEditMode.addFolderUsingTabs(title: Strings.savedTabsFolderTitle, tabList: tabManager.allTabs)) |
There was a problem hiding this comment.
What happens if you have 2 tabs opened in regular mode, 3 tabs in private mode and you add them?
Please double check this code works well in this case, priv mode tabs and regular tabs should be added and counted separately
There was a problem hiding this comment.
perhaps tabsForCurrentMode should be the correct getter, not tabManager.allTabs, haven't checked it though
There was a problem hiding this comment.
tabsForCurrentMode is the correct getter just checked.
Fix at cbe4bfc
iccub
approved these changes
Sep 8, 2021
iccub
suggested changes
Sep 9, 2021
...ntend/Browser/Toolbars/BottomToolbar/Menu/Bookmarks/AddEditBookmarkTableViewController.swift
Outdated
Show resolved
Hide resolved
iccub
approved these changes
Sep 9, 2021
Brandon-T
approved these changes
Sep 9, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #4132
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement