This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #4191: - Allow sharing Brave Playlist + Fix Time Formatting for >= 1-Hour #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
force-pushed
the
feature/BravePlaylistSharing
branch
from
8689678 to
1123726
Compare
iccub
suggested changes
Sep 17, 2021
Client/Frontend/Browser/Playlist/VideoPlayer/UI/VideoPlayerTrackbar.swift
Outdated
Show resolved
Hide resolved
Brandon-T
force-pushed
the
feature/BravePlaylistSharing
branch
from
93f265f to
543d56b
Compare
iccub
reviewed
Sep 28, 2021
|
|
||
| cacheAction.image = cacheState == .invalid ? #imageLiteral(resourceName: "playlist_download") : #imageLiteral(resourceName: "playlist_delete_download") | ||
| cacheAction.backgroundColor = #colorLiteral(red: 0.4509803922, green: 0.4784313725, blue: 0.8705882353, alpha: 1) | ||
|
|
||
| deleteAction.image = #imageLiteral(resourceName: "playlist_delete_item") | ||
| deleteAction.backgroundColor = #colorLiteral(red: 0.9176470588, green: 0.2274509804, blue: 0.05098039216, alpha: 1) | ||
|
|
||
| return UISwipeActionsConfiguration(actions: [deleteAction, cacheAction]) | ||
| shareAction.image = UIImage(systemName: "square.and.arrow.up") | ||
| shareAction.backgroundColor = #colorLiteral(red: 0.1764705926, green: 0.4980392158, blue: 0.7568627596, alpha: 1) |
There was a problem hiding this comment.
Don't we this or similar color hardcoded somewhere already?
There was a problem hiding this comment.
This colour was made up by me :( There is no design for it, so I chose one sort of in-between existing colours but one that would stand out enough on the swipe menu, and be colour blind friendly.
Brandon-T
force-pushed
the
feature/BravePlaylistSharing
branch
2 times, most recently
from
e3c255e to
4be96ce
Compare
Brandon-T
force-pushed
the
feature/BravePlaylistSharing
branch
from
4be96ce to
de311cb
Compare
iccub
approved these changes
Oct 4, 2021
iccub
added
the
blocked
iccub
removed
the
blocked
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #4191
Submitter Checklist:
NSLocalizableString()Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement