Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix # Display custom tokens in swap token list and move those with the selected network native token to the top of the list. #5011

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Feb 22, 2022

This pull request fixes #4981 #4980

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  1. Add few custom tokens to a network that supportsswap
  2. Go to swap screen
  3. click the From token field or To token field to go to the available token list
    (Native asset of the current selected network and custom tokens should be listed at the top)
    Note: If the token has been selected in one of the From or To fields, this token becomes not available in the other field.

Screenshots:

simulator_screenshot_76C2CE48-C32B-4548-B0DE-65976CB67A1C

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.36 milestone Feb 22, 2022
@nuo-xu nuo-xu requested review from kylehickinson and a team February 22, 2022 02:42
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
2 participants