Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5051: Added one more option in wallet settings to reset local transactions. #5056

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Fix #5051: Added one more option in wallet settings to reset local transactions. #5056

merged 3 commits into from
Mar 4, 2022

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Mar 4, 2022 •
edited
Loading

This pull request fixes #5051

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  1. make some transactions so they show up under account activity screen
  2. go to wallet settings and click rest transaction row
  3. (a pop up will show up to ask users to confirm)
  4. click reset in the pop up
  5. go back to account activity screen, the list of transactions should be gone.

Screenshots:

simulator_screenshot_C1468836-375D-4599-A4DA-AFBCFE2B54CC

simulator_screenshot_2FE29391-5FFF-45BA-93A1-EFCE33D26229

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.37 milestone Mar 4, 2022
@nuo-xu nuo-xu requested review from kylehickinson and a team March 4, 2022 15:56
kylehickinson
kylehickinson suggested changes Mar 4, 2022
View reviewed changes
BraveWallet/Settings/WalletSettingsView.swift Outdated
) {
Button(action: { isShowingResetTransactionAlert = true }) {
Text(Strings.Wallet.settingsResetTransactionTitle)
.foregroundColor(Color(.braveLabel))
Copy link
Collaborator

@kylehickinson kylehickinson Mar 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be brangeOrange or braveBlurpleTint since its a button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foregroundColor has been changed 8d8016d

@nuo-xu
Copy link
Contributor Author

nuo-xu commented Mar 4, 2022

All the copies are approved.

@nuo-xu nuo-xu merged commit 41c5169 into development Mar 4, 2022
@nuo-xu nuo-xu deleted the wallet-reset-local-transactions branch March 4, 2022 20:54
@Pavneet-Sing Pavneet-Sing mentioned this pull request Mar 4, 2022
Merged
25 tasks
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.

Reset local transactions from wallet settings.
3 participants
@nuo-xu @kylehickinson @iccub