Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5683: Add support for dynamic type on the url & bottom toolbars #5684

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Fix #5683: Add support for dynamic type on the url & bottom toolbars #5684

merged 5 commits into from
Jul 15, 2022

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #5683

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

See issue

Screenshots:

XS Large (Default) XL XXL AL
Simulator Screen Shot - iPhone 13 Pro - 2022-07-13 at 17 16 28 Simulator Screen Shot - iPhone 13 Pro - 2022-07-13 at 17 16 35 Simulator Screen Shot - iPhone 13 Pro - 2022-07-13 at 17 16 38 Simulator Screen Shot - iPhone 13 Pro - 2022-07-13 at 17 16 39 Simulator Screen Shot - iPhone 13 Pro - 2022-07-13 at 17 16 41

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson force-pushed the dynamic-font-url-bar branch 3 times, most recently from 21a7a0a to 2a42e55 Compare July 13, 2022 21:24
@kylehickinson kylehickinson force-pushed the dynamic-font-url-bar branch from 2a42e55 to c49e9ca Compare July 15, 2022 14:38
@kylehickinson kylehickinson requested a review from Brandon-T July 15, 2022 15:15
iccub
iccub approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functional questions I had are resolved

@kylehickinson kylehickinson added this to the 1.42 milestone Jul 15, 2022
@kylehickinson kylehickinson merged commit 9752378 into development Jul 15, 2022
@kylehickinson kylehickinson deleted the dynamic-font-url-bar branch July 15, 2022 18:07
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Brandon-T Brandon-T Brandon-T approved these changes

@StephenHeaps StephenHeaps StephenHeaps approved these changes

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.

Add support for Dynamic Type on the URL bar & toolbar
4 participants
@kylehickinson @Brandon-T @StephenHeaps @iccub