This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #6965: Duplicate add network requests can be shown #7047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
SuggestedNetworkView
. Error will dismiss the modal after as the add chain request is removed in core: https://github.com/brave/brave-core/blob/b31c48fff4b9aecdef95a9bba344f9329b3ab1e7/components/brave_wallet/browser/json_rpc_service.cc#L521handleWebpageRequestResponse
soSuggestedNetworkView
knows when to start/stop loading, and can now show an error alert when failing to add the networkThis pull request fixes #6965
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
Add Network Fixed:
add.network.request.mov
Add Network error alert (new):
add.chain.timeout.mov
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement