This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #6953: Fix filter list toggle states #7150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #6953
Make sure the toggle is in sync with the filter list and settings are stored even before filter lists are downloaded
Submitter Checklist:
NSLocalizableString()
Test Plan:
Note: The filter lists will not download until you enable the internet and restart the application. I don't know why component updater doesn't retry the download until you restart the app. This is an issue I'll look into but for now you have to restart the app to retry the downloads. The two toggles will not do anything until filter lists are downloaded.
d. Switch the toggles and ensure the changes are reflected on the filter lists (you can try to repeat this several times)
e. Switch the toggles on the filter lists and ensure the toggles are reflected on the Shields screen (you can also repeat this several times)
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement