Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7893: Browser Lock - Cancel Issue #7894

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

soner-yuksel
Copy link
Contributor

Summary of Changes

This pull request fixes #7893

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Enable Browser Lock
  • Put application to background
  • And Open App again
  • Check no cancel fro browser unlock

Screenshots:

RPReplay_Final1692300795.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added bug priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Aug 17, 2023
@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 17, 2023
@soner-yuksel soner-yuksel requested a review from iccub August 17, 2023 19:42
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 17, 2023 19:42
@soner-yuksel soner-yuksel self-assigned this Aug 17, 2023
@soner-yuksel soner-yuksel enabled auto-merge (squash) August 17, 2023 20:29
@soner-yuksel soner-yuksel merged commit d2a8fe6 into development Aug 17, 2023
@soner-yuksel soner-yuksel deleted the fix/browser-lock-issue branch August 17, 2023 20:56
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug priority/P1 A very extremely bad problem. We might push a hotfix for it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser Lock - Cancel Issue
2 participants