This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #8045: Default Browser Notification - Update (Text - Default Logic) #8067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
reviewed
Sep 14, 2023
soner-yuksel
force-pushed
the
enhancement/default-browser-notification
branch
from
c8b653e to
5a0f5d2
Compare
kylehickinson
approved these changes
Sep 15, 2023
iccub
approved these changes
Sep 18, 2023
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
… - Default Logic) (brave/brave-ios#8067)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #8045
Submitter Checklist:
NSLocalizableString()Test Plan:
Check If notification will be presented after opening an external link while browser is set default
Check new text
Reviewer Checklist:
QA/(Yes|No)bug/enhancement