Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Route auxclick through click
Browse files Browse the repository at this point in the history
Auditors: @bsclifton

There was only one case that I didn't do this and it turned out to be a problem for VMs for some reason.

Apparently the VM still gets click events and not auxclick events. Strange
  • Loading branch information
bbondy committed Feb 12, 2017
1 parent da801c7 commit 40d9979
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions js/components/tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,15 @@ class Tab extends ImmutableComponent {
}

onAuxClick (e) {
if (e.button === 1) {
this.onTabClosedWithMouse(e)
}
this.onClickTab(e)
}

onClickTab (e) {
this.setActiveFrame(e)
if (e.button === 1) {
this.onTabClosedWithMouse(e)
} else {
this.setActiveFrame(e)
}
}

get themeColor () {
Expand Down

2 comments on commit 40d9979

@bbondy
Copy link
Member Author

@bbondy bbondy commented on 40d9979 Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this just ended up being because my VM had C54 on it. Oh well this just makes it more consistent with the rest of the handling anyway.

@bsclifton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please # to comment.