update urlbar value on selection change

fix #8865
brave · May 15, 2017 · 9ac2ff6 · 9ac2ff6
1 parent bf55709
commit 9ac2ff6
Show file tree

Hide file tree

Showing 3 changed files with 290 additions and 122 deletions.
diff --git a/app/renderer/components/navigation/urlBar.js b/app/renderer/components/navigation/urlBar.js
@@ -247,6 +247,13 @@ class UrlBar extends React.Component {
       this.lastSuffix = ''
     }
 
+    // if there is no selection then we are not in autocomplete
+    // so make sure that this.lastValue is set to urlInput.value
+    if (this.urlInput.selectionStart === this.urlInput.selectionEnd) {
+      this.lastVal = this.urlInput.value
+      this.lastSuffix = ''
+    }
+
     const selectionStart = this.urlInput.selectionStart
     const newValue = [
       this.lastVal.slice(0, selectionStart),

diff --git a/test/lib/brave.js b/test/lib/brave.js
@@ -106,6 +106,8 @@ var exports = {
     SHIFT: '\ue008',
     BACKSPACE: '\ue003',
     DELETE: '\ue017',
+    LEFT: '\ue012',
+    RIGHT: '\ue014',
     DOWN: '\ue015',
     UP: '\ue013',
     PAGEDOWN: '\uE00F',