You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
This was something that @kjozwiak and I noticed during a working session. clientOptions such as verboseP are not passed in any of the roundtrip calls in ledger.js, (Just is {}) see:
The bat-client sends all of the current clientOptions in each round trip call, so there is some missed networking debug output when running LEDGER_VERBOSE=true.
This is a very small item but we should change this so that all outgoing ledger related requests are displayed.
The text was updated successfully, but these errors were encountered:
Test Plan
promoCode
in the profile folder with theKAM253
promoLEDGER_VERBOSE=true
After about 20-30 seconds, you should see the following output (originally it wasn't dumping any information into the terminal):
Original Issue
This was something that @kjozwiak and I noticed during a working session.
clientOptions
such asverboseP
are not passed in any of the roundtrip calls inledger.js
, (Just is{}
) see:https://github.com/brave/browser-laptop/blob/master/app/browser/api/ledger.js#L2109
https://github.com/brave/browser-laptop/blob/master/app/browser/api/ledger.js#L2181
https://github.com/brave/browser-laptop/blob/master/app/browser/api/ledger.js#L3105
The
bat-client
sends all of the currentclientOptions
in each round trip call, so there is some missed networking debug output when runningLEDGER_VERBOSE=true
.This is a very small item but we should change this so that all outgoing ledger related requests are displayed.
The text was updated successfully, but these errors were encountered: