Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Error tab cannot be reloaded or cloned #2826

Closed
luixxiul opened this issue Jul 30, 2016 · 6 comments · Fixed by #4881
Closed

Error tab cannot be reloaded or cloned #2826

luixxiul opened this issue Jul 30, 2016 · 6 comments · Fixed by #4881
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.6dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: An error tab cannot be reloaded or cloned.

Expected behavior: It should be reloaded and cloned

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.11.2 beta1
  • Steps to reproduce:
    1. Go to https://expired.badssl.com/
    2. Select "Reload" on the tab
    3. Select "Clone" on the tab
  • Screenshot if needed:
  • Any related issues:
@bbondy bbondy mentioned this issue Aug 2, 2016
Closed
@luixxiul luixxiul mentioned this issue Aug 10, 2016
Closed
@bbondy bbondy modified the milestones: 0.11.5dev, 0.11.6dev Aug 10, 2016
@bbondy bbondy modified the milestones: 1.0.0, 0.11.6dev Aug 23, 2016
@sarahhodne sarahhodne mentioned this issue Aug 24, 2016
Closed
@gulkily
Copy link

gulkily commented Sep 1, 2016

Possibly related: Changing only the anchor for the URL should not reload the page #2963

@bridiver
Copy link
Collaborator

bridiver commented Sep 1, 2016

reload/clone is intentionally disabled on most about/error pages. I'm not sure that disabling reload is necessary, but at the very least the options shouldn't appear in the context menu if they don't actually work. Thoughts @bbondy ?

@bsclifton bsclifton modified the milestones: 0.11.7dev, 1.0.0 Sep 1, 2016
@bbondy
Copy link
Member

bbondy commented Sep 3, 2016

We should definitely make this work, especially for connection error pages.

@bbondy bbondy modified the milestones: 0.12.1dev, 0.12.0dev Sep 3, 2016
@bbondy
Copy link
Member

bbondy commented Sep 9, 2016

moving to 0.12.2

@bbondy bbondy modified the milestones: 0.12.2dev, 0.12.1dev Sep 9, 2016
@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.2dev Sep 17, 2016
@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.4dev, 0.12.6dev Oct 4, 2016
@bbondy
Copy link
Member

bbondy commented Oct 10, 2016

@darkdh would you be able to take this one in 0.12.6 timeframe?

@bbondy bbondy assigned darkdh and unassigned bridiver Oct 10, 2016
@darkdh
Copy link
Member

darkdh commented Oct 10, 2016

sure thing

darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 18, 2016
@darkdh
Allow about pages to reload and clone
31438f2 
fix brave#2826

Auditors: @bridiver, @bbondy

Test Plan:
1. Generate any error pages(connection error, cert error, ...)
2. Clone/Reload should work properly

1. Go to any about pages
2. Clone/Reload should work properly
@darkdh darkdh mentioned this issue Oct 18, 2016
Merged
4 tasks
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 18, 2016
@darkdh
Allow about pages to reload and clone
5d09c00 
fix brave#2826

Auditors: @bridiver, @bbondy

Test Plan:
1. Generate any error pages(connection error, cert error, ...)
2. Clone/Reload should work properly (reload the original URL)

1. Go to any about pages
2. Clone/Reload should work properly (reload the original URL)
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 18, 2016
@darkdh
Allow about pages to reload and clone
61994b5 
fix brave#2826

Auditors: @bridiver, @bbondy

Test Plan:
1. Generate any error pages(connection error, cert error, ...)
2. Clone/Reload should work properly (reload the original URL)

1. Go to any about pages
2. Clone/Reload should work properly (reload the original URL)
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 22, 2016
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging a pull request may close this issue.

Allow about pages to reload and clone darkdh/browser-laptop
8 participants
@bridiver @bbondy @alexwykoff @gulkily @luixxiul @bsclifton @darkdh @srirambv