Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move page-level alerts to below the tabs bar, and add an overlap nub #6935

Closed
bradleyrichter opened this issue Jan 31, 2017 · 0 comments
Closed

Move page-level alerts to below the tabs bar, and add an overlap nub #6935

bradleyrichter opened this issue Jan 31, 2017 · 0 comments
Assignees
@jonathansampson
Labels
parity Features which should be supported in Brave since they're supported in other major browsers. QA/test-plan-required release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@bradleyrichter
Copy link
Contributor

Moving the alert bar (for tab-specific alerts) under the tabs bar will give the correct hierarchical appearance to the alert. (global alerts can remain in their top position.)

Adding an overlapping nub reduces the chance for exact spoofing.

similar example compliments of Chrome on OS X:
image
@bradleyrichter bradleyrichter added enhancement parity Features which should be supported in Brave since they're supported in other major browsers. labels Jan 31, 2017
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Jan 31, 2017
@jonathansampson jonathansampson mentioned this issue Jan 31, 2017
Merged
4 tasks
@bbondy bbondy modified the milestones: 0.13.3, 1.0.0 Feb 1, 2017
@bbondy bbondy removed this from the 0.13.5 milestone Feb 16, 2017
cezaraugusto added a commit that referenced this issue Apr 20, 2017
@cezaraugusto
Make notificationBar tab-specific
45a13d8 
Auditors: @bradleyrichter, @jonathansampson
Close #6935
cezaraugusto added a commit that referenced this issue Apr 20, 2017
@cezaraugusto
Make notificationBar tab-specific
fe72678 
Auditors: @bradleyrichter, @jonathansampson
Close #6935
cezaraugusto added a commit that referenced this issue Apr 20, 2017
@cezaraugusto
Make notificationBar tab-specific
e5ecc26 
Auditors: @bradleyrichter, @jonathansampson
Close #6935
cezaraugusto added a commit that referenced this issue Apr 20, 2017
@cezaraugusto
Make notificationBar tab-specific
ffc2d9b 
Auditors: @bradleyrichter, @jonathansampson
Close #6935
cezaraugusto pushed a commit that referenced this issue Apr 20, 2017
@jonathansampson @cezaraugusto
Make notificationBar tab-specific (#6939)
1d8588d 
Auditors: @bradleyrichter, @jonathansampson
Close #6935
@luixxiul luixxiul added this to the 0.15.1 milestone Apr 20, 2017
This was referenced May 2, 2017
Closed
Closed
@srirambv srirambv mentioned this issue May 2, 2017
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@jonathansampson jonathansampson

Labels
parity Features which should be supported in Brave since they're supported in other major browsers. QA/test-plan-required release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@jonathansampson @bbondy @luixxiul @bradleyrichter