Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor window actions, remove the whole frame prop (related to tabs) #8857

Closed
5 tasks done
NejcZdovc opened this issue May 12, 2017 · 1 comment · Fixed by #8858
Closed
5 tasks done

Refactor window actions, remove the whole frame prop (related to tabs) #8857

NejcZdovc opened this issue May 12, 2017 · 1 comment · Fixed by #8858
Assignees
@NejcZdovc
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component refactoring release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 12, 2017 •
edited by luixxiul
Loading

Test plan

#8858 (comment)

Describe the issue you encountered:
Refactor following window actions, remove the whole frame prop. This will address only actions related to tabs.

  • closeFrame
  • setTabHoverState
  • setTabBreakpoint
  • moveTab
  • setPreviewFrame
@NejcZdovc NejcZdovc added this to the 0.15.400 milestone May 12, 2017
@NejcZdovc NejcZdovc self-assigned this May 12, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 12, 2017
@NejcZdovc
Refactors window actions, remove the whole frame prop (related to tabs)
d3f66c2 
Resolves brave#8857

Auditors: @bsclifton @bridiver

Test Plan:
- try closing a tab
@NejcZdovc NejcZdovc mentioned this issue May 12, 2017
Merged
6 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 12, 2017
@NejcZdovc
Refactors window actions, remove the whole frame prop (related to tabs)
20039a1 
Resolves brave#8857

Auditors: @bsclifton @bridiver

Test Plan:
- try closing a tab
- hover over the tab and close button should be displayed
- resize window and check if tabs are changing (when really small, text should be hidden)
- reorder tabs with dnd
- try tabs tear off
- try moving tabs from one window to another
- try moving tab into next tab page, by dropping it on the tab page indicator
- try moving bookmark into bookmark folder
- try reordering bookmarks
- check if tab preview is working
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 12, 2017
@NejcZdovc
Refactors window actions, remove the whole frame prop (related to tabs)
751964c 
Resolves brave#8857

Auditors: @bsclifton @bridiver

Test Plan:
- try closing a tab
- hover over the tab and close button should be displayed
- resize window and check if tabs are changing (when really small, text should be hidden)
- reorder tabs with dnd
- try tabs tear off
- try moving tabs from one window to another
- try moving tab into next tab page, by dropping it on the tab page indicator
- try moving bookmark into bookmark folder
- try reordering bookmarks
- check if tab preview is working
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 12, 2017
@NejcZdovc
Refactors window actions, remove the whole frame prop (related to tabs)
d599d26 
Resolves brave#8857

Auditors: @bsclifton @bridiver

Test Plan:
- try closing a tab
- hover over the tab and close button should be displayed
- resize window and check if tabs are changing (when really small, text should be hidden)
- reorder tabs with dnd
- try tabs tear off
- try moving tabs from one window to another
- try moving tab into next tab page, by dropping it on the tab page indicator
- try moving bookmark into bookmark folder
- try reordering bookmarks
- check if tab preview is working
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 12, 2017
@NejcZdovc
Refactors window actions, remove the whole frame prop (related to tabs)
571f92f 
Resolves brave#8857

Auditors: @bsclifton @bridiver

Test Plan:
- try closing a tab
- hover over the tab and close button should be displayed
- resize window and check if tabs are changing (when really small, text should be hidden)
- reorder tabs with dnd
- try tabs tear off
- try moving tabs from one window to another
- try moving tab into next tab page, by dropping it on the tab page indicator
- try moving bookmark into bookmark folder
- try reordering bookmarks
- check if tab preview is working
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 12, 2017
@NejcZdovc
Refactors window actions, remove the whole frame prop (related to tabs)
b9aa47a 
Resolves brave#8857

Auditors: @bsclifton @bridiver

Test Plan:
- try closing a tab
- hover over the tab and close button should be displayed
- resize window and check if tabs are changing (when really small, text should be hidden)
- reorder tabs with dnd
- try tabs tear off
- try moving tabs from one window to another
- try moving tab into next tab page, by dropping it on the tab page indicator
- try moving bookmark into bookmark folder
- try reordering bookmarks
- check if tab preview is working
bsclifton added a commit that referenced this issue May 15, 2017
@bsclifton
Merge pull request #8858 from NejcZdovc/refactor/#8857-actions
21cfbf6 
Refactors window actions, remove the whole frame prop (related to tabs)
@bsclifton
Copy link
Member

Moving to 0.15.3xx; I don't feel confident about reverting in dev-channel

@bsclifton bsclifton modified the milestones: 0.15.300, 0.15.400 May 16, 2017
This was referenced May 23, 2017
Closed
Closed
Closed
This was referenced May 25, 2017
Closed
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component refactoring release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Refactors window actions, remove the whole frame prop (related to tabs) NejcZdovc/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv