-
Notifications
You must be signed in to change notification settings - Fork 970
Title is not updated when using navigation buttons #8908
Comments
Closing as a dupe of #7765. If I'm wrong about this (ex: title does not update on mouse over) please reopen. Thanks 😄 |
This is not a dupe, because as you can see in a gif if you hover over it nothing changes. I debug it a little bit and title is not set in our state (in #7765 everything is set ok, just DOM is not displayed correctly). So this regressed somewhere (race condition or something is not updating) when we were refactoring tabs. I think that this needs to be fixed in 0.15.30x, because this is something that is not happening in 0.15.2 and it's really bad. |
This is what causes the title to change: Looking at the code here, it looks like this was a known issue and a hacky work-around was put in place: cc: @NejcZdovc @bridiver |
Resolves brave#8908 Auditors: @bsclifton @bridiver Test Plan: - go to site clifton.io - create a history - click on back/forward buttons - check that title is always correct
Resolves brave#8908 Auditors: @bsclifton @bridiver Test Plan: - go to site clifton.io - create a history - click on back/forward buttons - check that title is always correct
Resolves #8908 Auditors: @bsclifton @bridiver Test Plan: - go to site clifton.io - create a history - click on back/forward buttons - check that title is always correct
Test plan
#8992 (comment)
yes
Title is not updated when using navigation buttons
macOS
8bb62f7
sometimes tab title is not display (location is shown)
title should be displayed
yes
no
not all the time but with few clicks you can see a problem
The text was updated successfully, but these errors were encountered: