This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Tab toolbar #59
Merged
Tab toolbar #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still visually ugly, will be fixed in follow up commits. Still also missing various parts of functionality.
| <span | ||
| className='prevTab fa fa-angle-left' | ||
| disabled={this.activeFrameIndex === 0} | ||
| onClick={this.onPrevFrame.bind(this)} /> |
There was a problem hiding this comment.
I thought these buttons were supposed to go to the previous/next tab set, not the previous/next tab? cc @bradleyrichter
There was a problem hiding this comment.
You are correct, I'll update before landing.
|
Looks good to me modulo comments. Awesome work! |
|
I changed to going prev/next page I think I like the old UX better though. Will be easy to revert that commit if others want after. Merging. |
This was referenced Nov 28, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still iterating on this but it's pretty usable for now. Would like to merge it so we can play with the UX and iterate from here.