Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Provide popup coords on keypress #8036

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Provide popup coords on keypress #8036

merged 1 commit into from
Apr 7, 2017

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Apr 2, 2017 •
edited by bsclifton
Loading

Test Plan

  1. Use Preferences > Security to change password manager to LastPass
  2. Tab focus from address-bar to LastPass icon
  3. Press Enter
  4. Popup should open beneath extension icon

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #8034

@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 2, 2017
@jonathansampson jonathansampson self-assigned this Apr 2, 2017
@jonathansampson jonathansampson requested a review from bridiver April 2, 2017 07:25
@jonathansampson jonathansampson force-pushed the extension-popup-position branch from e173261 to 9a77992 Compare April 2, 2017 07:28
@cezaraugusto
Copy link
Contributor

@jonathansampson can you rebase that?

@jonathansampson jonathansampson force-pushed the extension-popup-position branch from 9a77992 to 0532d37 Compare April 6, 2017 07:33
@jonathansampson
Copy link
Collaborator Author

@cezaraugusto Just did another rebase. Let me know if that worked.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 6, 2017 •
edited
Loading

@jonathansampson you have some lint errors, can you please fix it?

@jonathansampson jonathansampson force-pushed the extension-popup-position branch from 9b85b0b to 4d5500b Compare April 6, 2017 21:06
@jonathansampson
Copy link
Collaborator Author

@NejcZdovc Linting issues resolved.

@bsclifton bsclifton self-requested a review April 7, 2017 18:49
bsclifton
bsclifton approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested; works great 😄

@bsclifton bsclifton merged commit d3f83cb into master Apr 7, 2017
@bsclifton bsclifton deleted the extension-popup-position branch April 7, 2017 22:45
@josiah-keller josiah-keller mentioned this pull request Apr 8, 2017
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@jonathansampson jonathansampson

Labels
bug feature/extensions feature/keyboard-shortcuts feature/password-manager QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathansampson @cezaraugusto @NejcZdovc @bsclifton